Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initiate Combobox input value with root default value #104

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

coopbri
Copy link
Contributor

@coopbri coopbri commented Jul 29, 2024

Description

Task link: N/A
  • Initiate Combobox input value with Combobox root default value, if supplied
    • Previously, the value was always set to initialize with "" so would override any passed default value

Test Steps

  • Make sure Combobox accepts and displays a default value in the input field component part

Copy link

changeset-bot bot commented Jul 29, 2024

🦋 Changeset detected

Latest commit: 76b8623

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@omnidev/sigil Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sigil-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 5:23am

@coopbri coopbri merged commit 273ffb2 into master Jul 29, 2024
3 checks passed
@coopbri coopbri deleted the fix/combobox-input-value branch July 29, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant