Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Amplenote origins to cors config #4188

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

debanjandhar12
Copy link
Contributor

Hello,

Amplenote is a note-taking app similar to Obsidian and Logseq. I'm currently working on developing a plugin for Amplenote that syncs with Omnivore. However, I am facing issues due to CORS.

This change will fix that issue. Would it be possible to merge this PR?

Copy link

vercel bot commented Jul 10, 2024

@debanjandhar12 is attempting to deploy a commit to the omnivore Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Jul 10, 2024

CLA assistant check
All committers have signed the CLA.

@jacksonh
Copy link
Contributor

Thanks @debanjandhar12, so i guess this is a chromium app? Just wondering are you testing on both desktop and mobile? I've noticed with some of the others it gives different origins based on the platform.

Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
omnivore-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 2:45am
omnivore-prod ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 2:45am

@debanjandhar12
Copy link
Contributor Author

debanjandhar12 commented Jul 11, 2024

Thanks @debanjandhar12, so i guess this is a chromium app? Just wondering are you testing on both desktop and mobile? I've noticed with some of the others it gives different origins based on the platform.

@jacksonh,

It is a note-taking app available on three platforms: web, desktop, and mobile, and I have tested those. The Web App Origin is https://plugins.amplenote.com/, while the Desktop App Origin is amplenote-handler://bundle. Interestingly, the mobile app appears to bypass CORS restrictions entirely. I am guessing but maybe the mobile app is doing something like this.

@jacksonh jacksonh merged commit b6d0c27 into omnivore-app:main Jul 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants