Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: different sizes of cards #107

Merged
merged 5 commits into from
Feb 9, 2024
Merged

fix: different sizes of cards #107

merged 5 commits into from
Feb 9, 2024

Conversation

danmaninc
Copy link
Collaborator

@danmaninc danmaninc commented Jan 30, 2024

This PR will fix different sizes of cards.
Also, this PR would possibly include #85 (adding a plugin for breakpoints). It will be included in separate PR.

The changes which are introduced by this PR:

  • Grid
    • section containers: flex-direction: row from the 2xl breakpoint (>1536px laptop)
    • various grid-template-columns for different breakpoints
      • 1 for phones
      • 2 for sm (tablets) and 2xl (since the flex-direction: row, there is less space for 3 columns)
      • 3 for xl (grid takes full container width, since flex-direction: column) and 4xl (too much space, excessive stretch)
  • Basis size for GroupCard component (so it will be not so small)
  • Margins
    • fix of inconsistent margins (2rem now between each section of GroupCards in dashboard)

@danmaninc danmaninc linked an issue Jan 30, 2024 that may be closed by this pull request
@danmaninc danmaninc marked this pull request as ready for review February 7, 2024 08:22
@danmaninc danmaninc self-assigned this Feb 7, 2024
@danmaninc danmaninc merged commit 2782871 into main Feb 9, 2024
@danmaninc danmaninc deleted the cards-size-96 branch February 9, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix different sizes of cards on Dashboard table
1 participant