Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sysman CTS bug in Device & Init suites #56

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Fix Sysman CTS bug in Device & Init suites #56

merged 3 commits into from
Jul 29, 2024

Conversation

vishnu-khanth
Copy link
Contributor

Related-To: VLCLJ-2228

bellekal
bellekal reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@bellekal bellekal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modify commit header - It's not windows specific. It should reflect your changes.

It would be better if you can add commit message on the background for this change and purpose. Thanks

@vishnu-khanth vishnu-khanth changed the title Fix for issues in Windows for Sysman Device and Init CTS suites Unset ZES_ENABLE_SYSMAN for Sysman CTS tests where both zeInit & zesInit are used Jul 17, 2024
@vishnu-khanth vishnu-khanth changed the title Unset ZES_ENABLE_SYSMAN for Sysman CTS tests where both zeInit & zesInit are used Unset ZES_ENABLE_SYSMAN for Sysman CTS where both zeInit & zesInit are used Jul 17, 2024
@vishnu-khanth vishnu-khanth force-pushed the LNL_device_CTS_dbg branch 2 times, most recently from 8a5274d to a53e72c Compare July 17, 2024 11:21
@vishnu-khanth
Copy link
Contributor Author

Modify commit header - It's not windows specific. It should reflect your changes.

It would be better if you can add commit message on the background for this change and purpose. Thanks

Updated as per the suggestion

@vishnu-khanth vishnu-khanth changed the title Unset ZES_ENABLE_SYSMAN for Sysman CTS where both zeInit & zesInit are used Fix Sysman CTS bug in Device & Init suites Jul 17, 2024
@vishnu-khanth
Fix Sysman CTS bug in Device & Init suites
33fa740 
 * Unsetting ZES_ENABLE_SYSMAN so that Sysman is not initialized through
   zeInit itself.
 * Done these to tests where both zeInit & zesInit are used.

Related-To: VLCLJ-2228
Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
@vishnu-khanth
Fix Sysman CTS bug in Device & Init suites
59649ae 
 * Unsetting ZES_ENABLE_SYSMAN so that Sysman is not initialized through
   zeInit itself.
 * Done these to tests where both zeInit & zesInit are used.

Related-To: VLCLJ-2228
Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
joshuaranjan
joshuaranjan approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@joshuaranjan joshuaranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

@vishnu-khanth
Fix Sysman CTS bug in Device & Init suites
8f86109 
 * Unsetting ZES_ENABLE_SYSMAN so that Sysman is not initialized through
   zeInit itself.
 * Done these to tests where both zeInit & zesInit are used.

Related-To: VLCLJ-2228
Signed-off-by: Vishnu Khanth <vishnu.khanth.b@intel.com>
@bellekal bellekal merged commit efcb119 into oneapi-src:master Jul 29, 2024
11 checks passed
@vishnu-khanth vishnu-khanth deleted the LNL_device_CTS_dbg branch July 29, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bellekal bellekal bellekal left review comments

@joshuaranjan joshuaranjan joshuaranjan approved these changes

@Jemale Jemale Jemale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vishnu-khanth @Jemale @joshuaranjan @bellekal