Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent reinit when zes/ze handles have already been retrieved #192

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Prevent reinit when zes/ze handles have already been retrieved #192

merged 1 commit into from
Sep 4, 2024

Conversation

nrspruit
Copy link
Contributor

@nrspruit nrspruit commented Sep 3, 2024

  • Given ze or zes driver get has been called, then one cannot allow for the ddi table to be reinit to avoid breaking the user's existing handles.

@nrspruit
Prevent reinit when zes/ze handles have already been retrieved
28cc873 
- Given ze or zes driver get has been called, then one cannot allow for
  the ddi table to be reinit to avoid breaking the user's existing
handles.

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Jemale
Jemale approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@Jemale Jemale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the program instrumentation check not needed anymore?

@nrspruit
Copy link
Contributor Author

nrspruit commented Sep 3, 2024

why is the program instrumentation check not needed anymore?

It is replaced with the zeInuse check.

The problem with instrumentation was the calls to L0 apis during zeinit().

With the new zeInuse, calls to zeDriverGet while in the driver_check will show up and when ze has already started to be used.

so, this fix includes the support for handling program instrumentation cases.

@nrspruit nrspruit merged commit 0f1a1de into oneapi-src:master Sep 4, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jemale Jemale Jemale approved these changes

@lisanna-dettwyler lisanna-dettwyler Awaiting requested review from lisanna-dettwyler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nrspruit @Jemale