Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Alexandra <alexandra.epanchinzeva@intel.com>
  • Loading branch information
napetrov and aepanchi authored Sep 18, 2023
1 parent bac4594 commit 18740de
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 14 deletions.
6 changes: 3 additions & 3 deletions INSTALL.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ Required Software:

For details, see [System Requirements for oneDAL](https://www.intel.com/content/www/us/en/developer/articles/system-requirements/system-requirements-for-oneapi-data-analytics-library.html).

## Docker development environement
## Docker Development Environment

[Docker file](https://github.com/oneapi-src/oneDAL/tree/master/dev) with oneDAL development environemnt
is avaialbe as alternative for setting up environemnt manually.
[Docker file](https://github.com/oneapi-src/oneDAL/tree/master/dev) with the oneDAL development environment
is available as an alternative to the manual setup.

## Installation Steps
1. Clone the sources from GitHub\* as follows:
Expand Down
2 changes: 1 addition & 1 deletion dev/bazel/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
*******************************************************************************/-->
# Bazel Guide
## Install Bazel on Linux
1. Use bazelisk
1. Use Bazelisk
```sh
wget -O bazel https://github.com/bazelbuild/bazelisk/releases/download/v1.18.0/bazelisk-linux-amd64
```
Expand Down
12 changes: 6 additions & 6 deletions dev/docker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@
* limitations under the License.
*******************************************************************************/-->

# Docker dev environemnt
## How to use
This is simple docker dev environment intended for oneDAL development and build process.
It does include dependencies for building all oneDAL components through both make and bazel
# Docker Development Environment
## How To Use
There is a simple docker dev environment for the oneDAL development and build process.
It includes dependencies for building all oneDAL components with ``make`` and ``bazel``

Note: docker setup assumes that it's executed from oneDAL checkouted repo and copy repo files inside container
Note: The docker setup assumes that it is executed from the oneDAL repo and copies repo files inside the container

Just run:
For that, run:
```sh
docker run -it onedal-dev /bin/bash
```
6 changes: 2 additions & 4 deletions dev/docker/onedal-dev.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ ENV CONDA_DIR /opt/conda
RUN wget --quiet https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86_64.sh -O ~/miniconda.sh && \
/bin/bash ~/miniconda.sh -b -p /opt/conda

# Put conda in path so we can use conda activate
# Put conda in path to use conda activate
ENV PATH=$CONDA_DIR/bin:$PATH

# Installing environment for base development dependencies
Expand All @@ -54,8 +54,6 @@ RUN .ci/env/openblas.sh
# Installing MKL dependency
RUN ./dev/download_micromkl.sh

# Installing TBB dependency
# Installing oneTBB dependency
RUN ./dev/download_tbb.sh

# Installing doc build dependency
#RUN pip3 install -r docs/requirements.txt

0 comments on commit 18740de

Please sign in to comment.