-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add multithreaded searches for all Decision Forest trees simultaneously #2441
Merged
Alexsandruss
merged 8 commits into
oneapi-src:master
from
icfaust:DFS_oneDAL_threader_for
Aug 28, 2023
Merged
[Feature] Add multithreaded searches for all Decision Forest trees simultaneously #2441
Alexsandruss
merged 8 commits into
oneapi-src:master
from
icfaust:DFS_oneDAL_threader_for
Aug 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icfaust
requested review from
Alexsandruss,
samir-nasibli and
KulikovNikita
as code owners
July 20, 2023 22:23
/intelci: run |
/intelci: run |
Common PreCommit job with intel/scikit-learn-intelex#1333: http://intel-ci.intel.com/ee459771-cca8-f11a-93c5-a4bf010d0e2e |
Alexsandruss
approved these changes
Aug 28, 2023
KulikovNikita
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very rough implementation. So I hope it will be revisited later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As of now, only single threaded DFS and BFS exist. This uses dal::detail::threader_for to make it run all trees simultaneously. This provides a speedup for Scikit-Learn-intelex RF preview.
Changes proposed in this pull request: