Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add multithreaded searches for all Decision Forest trees simultaneously #2441

Merged
merged 8 commits into from
Aug 28, 2023

Conversation

icfaust
Copy link
Contributor

@icfaust icfaust commented Jul 20, 2023

Description

As of now, only single threaded DFS and BFS exist. This uses dal::detail::threader_for to make it run all trees simultaneously. This provides a speedup for Scikit-Learn-intelex RF preview.
Changes proposed in this pull request:

  • Add new overloaded method for traverse_depth_first decision forest model (common.hpp)
  • Add new overloaded method for traverse_breadth_first decision forest model (common.hpp)
  • Add header to dal threading to decision forest common.hpp

@icfaust
Copy link
Contributor Author

icfaust commented Jul 21, 2023

/intelci: run

@Alexsandruss
Copy link
Contributor

/intelci: run

@Alexsandruss
Copy link
Contributor

Copy link
Contributor

@KulikovNikita KulikovNikita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very rough implementation. So I hope it will be revisited later

@Alexsandruss Alexsandruss merged commit e7578ee into oneapi-src:master Aug 28, 2023
12 checks passed
@icfaust icfaust deleted the DFS_oneDAL_threader_for branch November 16, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement interfaces Update interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants