Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: updated github PR templates #2828

Merged
merged 4 commits into from
Sep 30, 2024
Merged

MAINT: updated github PR templates #2828

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df44de5
MAINT: updated github PR templates
samir-nasibli Jun 25, 2024
37410f1
Update pull_request_template.md
samir-nasibli Sep 18, 2024
7d8b2a5
Merge branch 'oneapi-src:main' into maint/pr_template
samir-nasibli Sep 18, 2024
5a8d065
Update PR template; add PR checklist job
Alexsandruss Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
# Description
Please include a summary of the change. For large or complex changes please include enough information to introduce your change and explain motivation for it.
### Description
_Add a comprehensive description of proposed changes_

Changes proposed in this pull request:
-
-
-
Fixes # - _issue number(s) if exists_
Alexsandruss marked this conversation as resolved.
Show resolved Hide resolved

- [ ] I have reviewed my changes thoroughly before submitting this pull request.
- [ ] I have commented my code, particularly in hard-to-understand areas.
- [ ] I have updated the documentation to reflect the changes, if necessary (updated in # - _add PR number_)
- [ ] The unit tests pass successfully.
- [ ] I have run it locally and tested the changes extensively.
- [ ] I have resolved any merge conflicts that might occur with the base branch.
- [ ] Git commit message contains an appropriate signed-off-by string _(see [CONTRIBUTING.md](https://github.com/oneapi-src/oneDAL/blob/main/CONTRIBUTING.md#pull-requests) for details)_
samir-nasibli marked this conversation as resolved.
Show resolved Hide resolved
- [ ] I have added a respective label(s) to PR if I have a permission for that.