Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Coverity fixes 2025.0 #2890

Merged
merged 6 commits into from
Sep 7, 2024
Merged

[bug] Coverity fixes 2025.0 #2890

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a92ccf9
Update kdtree_knn_classification_train_dense_default_impl.i
icfaust Sep 4, 2024
ff37e06
Update kdtree_knn_classification_train_dense_default_impl.i
icfaust Sep 4, 2024
f05cd1b
Merge branch 'oneapi-src:main' into dev/coverity-2025_0
icfaust Sep 5, 2024
c99f49d
Update kdtree_knn_classification_train_dense_default_impl.i
icfaust Sep 6, 2024
e6528a6
Update kdtree_knn_classification_train_dense_default_impl.i
icfaust Sep 6, 2024
f8a8ea6
Merge branch 'oneapi-src:main' into dev/coverity-2025_0
icfaust Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...l/src/algorithms/k_nearest_neighbors/kdtree_knn_classification_train_dense_default_impl.i
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ algorithmFpType KNNClassificationTrainBatchKernel<algorithmFpType, training::def
algorithmFpType * subSamples, size_t subSampleCapacity, Status & status)
{
algorithmFpType samples[__KDTREE_MEDIAN_RANDOM_SAMPLE_COUNT + 1];
const size_t sampleCount = sizeof(samples) / sizeof(samples[0]);
const size_t sampleCount = __KDTREE_MEDIAN_RANDOM_SAMPLE_COUNT + 1;

if (end - start <= sampleCount)
{
Expand Down Expand Up @@ -589,7 +589,11 @@ algorithmFpType KNNClassificationTrainBatchKernel<algorithmFpType, training::def

size_t sumMid = 0;
size_t i = 0;
for (; i < sampleCount; ++i)
// this iterates through the masterHist histogram and finds the median
// in almost all circumstances the break in the if statement will trigger
// unless masterHist does not contain sufficient data to exceed
// (end - start)/2 by the last bin.
for (; i < sampleCount - 1; ++i)
{
if (sumMid + masterHist[i] > (end - start) / 2)
{
Expand Down