Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing dependencies to compute probabilities function #2904

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Add missing dependencies to compute probabilities function #2904

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9081abc
Add deps to at_device function
avolkov-intel Sep 18, 2024
469062a
Clang-format
avolkov-intel Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cpp/oneapi/dal/backend/primitives/objective_function/logloss_dpc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ sycl::event compute_probabilities(sycl::queue& q,
auto fill_event = fill<Float>(q, probabilities, Float(1), deps);
using oneapi::dal::backend::operator+;

Float w0 = fit_intercept ? parameters.get_slice(0, 1).at_device(q, 0l) : 0; // Poor perfomance
Float w0 =
fit_intercept ? parameters.get_slice(0, 1).at_device(q, 0l, deps) : 0; // Poor perfomance
ndview<Float, 1> param_suf = fit_intercept ? parameters.get_slice(1, p + 1) : parameters;

sycl::event gemv_event;
Expand Down Expand Up @@ -87,7 +88,8 @@ sycl::event compute_probabilities_sparse(sycl::queue& q,
const std::int64_t p = parameters.get_dimension(0) - (fit_intercept ? 1 : 0);

auto fill_event = fill<Float>(q, probabilities, Float(1), deps);
Float w0 = fit_intercept ? parameters.get_slice(0, 1).at_device(q, 0l) : 0; // Poor perfomance
Float w0 =
fit_intercept ? parameters.get_slice(0, 1).at_device(q, 0l, deps) : 0; // Poor perfomance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the fill event has no deps with w0 computation looks good

ndview<Float, 1> param_suf = fit_intercept ? parameters.get_slice(1, p + 1) : parameters;

sycl::event gemv_event;
Expand Down