[oneDPL][ranges] An implementation fix for a random access range without operator[] and size() method #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…without operator[] and size() method
…ut operator[] and size() method
MikeDvorskiy
force-pushed
the
dev/mdvorski/ranges_api_ra_impl_fix
branch
from
a686234 to
0b537e6
Compare
…without operator[] and size() method: common test code for the all ranges test cases
…ut operator[] and size(); any_of, all_of, none_of, find_if, find, find_if_not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[oneDPL][ranges] + implementation fix for a random access range without operator[] and size() method.
Update: Discussed offline with @rarutyun.
The approach has a significant downside - range type is being changed, causing by a type-wrapper in the code.
The original issue should be discussed additionally with team and the architect in particular.
(As an option - to introduce
oneapi::dpl::subscript_operator_fnglobal functor object with correspondingoperator()overloads and use the function instead ofoperator[]everywhere on oneDPL for ranges.)