Optimization of __serial_merge function
#1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…optimization of __serial_merge function Signed-off-by: Sergey Kopienko <sergey.kopienko@intel.com>
SergeyKopienko
requested review from
dmitriy-sobolev,
akukanov,
MikeDvorskiy,
mmichel11 and
danhoeflinger
Signed-off-by: Sergey Kopienko <sergey.kopienko@intel.com>
SergeyKopienko
force-pushed
the
dev/skopienko/serial_merge
branch
from
bcc6675 to
d3d863d
Compare
include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_merge.h
Outdated
Show resolved
Hide resolved
mmichel11
reviewed
Dec 18, 2024
include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_merge_sort.h
Outdated
Show resolved
Hide resolved
…fix review comment: The uninitialized variables... Signed-off-by: Sergey Kopienko <sergey.kopienko@intel.com>
Signed-off-by: Sergey Kopienko <sergey.kopienko@intel.com>
Signed-off-by: Sergey Kopienko <sergey.kopienko@intel.com>
include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_merge.h
Outdated
Show resolved
Hide resolved
…pienko/serial_merge
MikeDvorskiy
previously approved these changes
Dec 18, 2024
include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_merge.h
Outdated
Show resolved
Hide resolved
include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_merge.h
Outdated
Show resolved
Hide resolved
include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_merge.h
Outdated
Show resolved
Hide resolved
…fix review comment: __rng3_idx is redefined in the loop below. Signed-off-by: Sergey Kopienko <sergey.kopienko@intel.com>
…fix review comment: Let's use _Index instead of auto, because the type is known. Signed-off-by: Sergey Kopienko <sergey.kopienko@intel.com>
…fix review comment: A nitpick: __rng1_idx_less__n1 -> __rng1_idx_less_n1 Signed-off-by: Sergey Kopienko <sergey.kopienko@intel.com>
dmitriy-sobolev
previously approved these changes
Dec 18, 2024
…fix review comment: rewrite to one ternary operator Signed-off-by: Sergey Kopienko <sergey.kopienko@intel.com>
…fix review comment: rewrite to one ternary operator with additional ( and ) Signed-off-by: Sergey Kopienko <sergey.kopienko@intel.com>
…fix self review comment: declare __start1 and __start2 as const Signed-off-by: Sergey Kopienko <sergey.kopienko@intel.com>
….h - fix review comment: remove auto for __find_start_point return type Signed-off-by: Sergey Kopienko <sergey.kopienko@intel.com>
danhoeflinger
previously approved these changes
Dec 18, 2024
mmichel11
previously approved these changes
Dec 18, 2024
dmitriy-sobolev
previously approved these changes
Dec 18, 2024
….h - apply GitHUB clang format Signed-off-by: Sergey Kopienko <sergey.kopienko@intel.com>
SergeyKopienko
dismissed stale reviews from dmitriy-sobolev, mmichel11, and danhoeflinger
via
cbba810
SergeyKopienko
requested review from
dmitriy-sobolev,
mmichel11 and
danhoeflinger
|
Unfortunately clang-formatting has been fixed. So approves required again. |
danhoeflinger
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we make optimization of
__serial_mergefunction.The justification: previous implementation is too complicated:
With this new implementation of
__serial_mergefunction we have significant performance profit formergeandmerge_sortalgorithms on all data sizes.