Fix sub-group load/store extension disabling logic #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
dev/dmitriy-sobolev/sycl2020-fallback
to
main
December 23, 2024 10:55
dmitriy-sobolev
force-pushed
the
dev/dmitriy-sobolev/sg-load
branch
from
fee39ab to
0c0eae5
Compare
| @@ -598,7 +602,7 @@ struct __parallel_copy_if_static_single_group_submitter<_Size, _ElemsPerItem, _W | |||
| const ::std::uint16_t __subgroup_id = __subgroup.get_group_id(); | |||
| const ::std::uint16_t __subgroup_size = __subgroup.get_local_linear_range(); | |||
|
|
|||
| #if _ONEDPL_SYCL_SUB_GROUP_LOAD_STORE_PRESENT | |||
| #if _ONEDPL_LIBSYCL_SUB_GROUP_LOAD_STORE_PRESENT | |||
There was a problem hiding this comment.
-
This is a "logic mix" of preprocessor code and C++ code.... It looks a mess..
I would recommend "take a look/imagine" on C++ code which remains after the preprocessor keeps one branch "#if" and the other branch "#else" and make the code clean-up (here and everywhere in that PR). -
BTW,
_ONEDPL_LIBSYCL_SUB_GROUP_LOAD_STORE_PRESENTis defined as identical zero.
https://github.com/oneapi-src/oneDPL/pull/1979/files?diff=split&w=0#diff-521f7db06a55567c1a1dffa855dde585fb6bc5fbe8633d19b528356e3a501ea0R91
M.b. it makes sense to remove the branches_ONEDPL_LIBSYCL_SUB_GROUP_LOAD_STORE_PRESENTat all?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code sections which use
sycl::sub_group::<load()|store()>DPC++ extension are not entirely disabled. Non-template expressions are still checked by a compiler even if they are within a discardedif constexprbranch.This makes the code non-compatible with compilers other than DPC++, and it results in a deprecation warning with the most recent DPC++ builds.
A mock-up example: https://godbolt.org/z/svhnY14r5
Even though the extension is deprecated, it still may make sense to keep the surrounding logic in case it can be reused with #1976 vector load/store or with
SYCL_EXT_ONEAPI_GROUP_LOAD_STOREextension.