[tests][LAPACK] Avoid cuSOLVER bug in *trd tests #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/intelci: run |
1 similar comment
|
/intelci: run |
rachelertl
approved these changes
Jun 4, 2024
ericlars
approved these changes
Jun 4, 2024
jadurazo
approved these changes
Jun 4, 2024
normallytangent
pushed a commit
to normallytangent/oneMKL
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The LAPACK *trd (sytrd, hetrd) tests fail with cuSOLVER backend during the off-diagonal check. This check compares the superdiagonal of A (for upper case; otherwise subdiagonal for lower case) with the output vector e, which contains the off-diagonal elements of the tridiagonal matrix. This appears to expose a legitimate, albeit relatively minor, bug in cuSOLVER for the upper case, where the first element of the superdiagonal of A, A[0,1], is always -1. The rest of the elements of the superdiagonal are equal to the values in the output e vector, which contains the off-diagonal elements of the tridiagonal matrix.
Since the lower case does not appear to have this bug in cuSOLVER, the input being tested was changed to test the lower case. Additionally a typo was fixed in the test to use the correct leading dimension when accessing the A matrix.
Fixes #231
Checklist
All Submissions
Do all unit tests pass locally? cusolver_tests.log
Have you formatted the code using clang-format? N/A
Bug fixes
GitHub issue or in this PR)? Run regular unit tests.