[DFT][CMake] Check CUDA support with portFFT before using it as a target #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The portFFT backends targets Nvidia by default * In some situations, this causes a failure whilst compiling (CUDA might not be installed) * This checks the target is supported before use
Rbiessy
reviewed
Jun 12, 2024
There was a problem hiding this comment.
Can you also remove the CMAKE_CXX_FLAGS in the GitHub CI for portFFT? https://github.com/oneapi-src/oneMKL/blob/develop/.github/workflows/pr.yml#L27
I think the CI in the PR will take these changes into account.
Done in 78a3eb5 |
Rbiessy
approved these changes
Jun 12, 2024
|
@mkrainiuk, @rscohn2 It'd be great to have your input. |
|
Looks good. It will simplify use for non nvidia users. |
rscohn2
approved these changes
Jun 13, 2024
normallytangent
pushed a commit
to normallytangent/oneMKL
that referenced
this pull request
Aug 6, 2024
…get (oneapi-src#511) * The portFFT backends targets Nvidia by default * In some situations, this causes a failure whilst compiling (CUDA might not be installed) * This checks the target is supported before use This solves the issue in PR oneapi-src#495
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This solves the issue in the PR at #495 (comment)
Checklist
All Submissions