Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selective test (#10) #513

Merged
merged 3 commits into from
Jul 2, 2024
Merged

selective test (#10) #513

merged 3 commits into from
Jul 2, 2024

Conversation

rscohn2
Copy link
Member

@rscohn2 rscohn2 commented Jun 13, 2024

Bring back selective testing: #509

Fixes issues:

  • Selective test on PR, full test on merge to develop
  • Filters *.md, docs, and third-party-programs. I did not filter on scripts because it isn't easy to know if a script affects build
  • Restructuring for testing: node .github/scripts/domain-check.js to run tests

dnhsieh-intel
dnhsieh-intel approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@dnhsieh-intel dnhsieh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you! I only have some minor comments.

.github/scripts/domain-check.js Show resolved Hide resolved
.github/workflows/pr.yml Outdated Show resolved Hide resolved
@rscohn2 rscohn2 requested a review from Rbiessy July 1, 2024 23:16
Rbiessy
Rbiessy approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@Rbiessy Rbiessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with javascript but this solution looks good to me and simple enough for anyone to adapt.

@rscohn2 rscohn2 merged commit d6bd86b into oneapi-src:develop Jul 2, 2024
6 checks passed
@rscohn2 rscohn2 deleted the dev/selective-again branch July 2, 2024 17:09
normallytangent pushed a commit to normallytangent/oneMKL that referenced this pull request Aug 6, 2024
@rscohn2 @normallytangent
selective test (oneapi-src#10) (oneapi-src#513)
ca9c045
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnhsieh-intel dnhsieh-intel dnhsieh-intel approved these changes

@Rbiessy Rbiessy Rbiessy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rscohn2 @Rbiessy @dnhsieh-intel