Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNG] Added -fsycl -fsycl-device-code-split=per_kernel at the linking stage to have device code #533

Conversation

egrabovskaya
Copy link
Contributor

@egrabovskaya egrabovskaya commented Jul 11, 2024

Description

We must pass -fsycl flag at the linking stage in addition to the compilation stage so that device code is added to executable file from object file on Windows.
Otherwise, there is the failure in Device API tests and example: No kernel named ZTSZZN12moments_testIN6oneapi3mkl3rng6device13philox4x32x10ILi1EEENS3_7uniformIfNS3_14uniform_method8standardEEEEclIN4sycl3_V15queueEEEvT_ENKUlRNSD_7handlerEE_clESH_EUlNSD_4itemILi1ELb1EEEE was found -46 (PI_ERROR_INVALID_KERNEL_NAME)

Fixes # (GitHub issue)

Checklist

All Submissions

  • Do all unit tests pass locally? Attach a log.
    logs_win_static.txt
  • Have you formatted the code using clang-format?

New interfaces

  • Have you provided motivation for adding a new feature as part of RFC and
    it was accepted? # (RFC)
  • What version of oneAPI spec the interface is targeted?
  • Complete New features checklist

New features

  • Have you provided motivation for adding a new feature?
  • Have you added relevant tests?

Bug fixes

  • Have you added relevant regression tests?
  • Have you included information on how to reproduce the issue (either in a
    GitHub issue or in this PR)?

@egrabovskaya egrabovskaya force-pushed the dev/egrabovs/MKLD-17512_device_tests_example_failures_fix branch from 4a2da51 to 5890883 Compare July 15, 2024 10:13
@egrabovskaya egrabovskaya merged commit 28e7aa9 into oneapi-src:develop Jul 18, 2024
6 checks passed
normallytangent pushed a commit to normallytangent/oneMKL that referenced this pull request Aug 6, 2024
… stage to have device code because of failures on windows (oneapi-src#533)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants