Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLAS][DFT][SPARSE][TESTS] Remove .template from get_host_access to fix build #534

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

JackAKirk
Copy link
Contributor

Remove .template from get_host_access to fix build. This is also cleaner code.

This fixes the build that became broken apparently due to a clang change: llvm/llvm-project#94049

Note that a dpc++ patch is also required to fix the build due to an unrelated issue to the one described above:
intel/llvm#14529

This fixes the build.

Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
@JackAKirk JackAKirk changed the title Remove .template from get_host_access to fix build [BLAS] Remove .template from get_host_access to fix build Jul 12, 2024
@Rbiessy
Copy link
Contributor

Rbiessy commented Jul 12, 2024

Thanks for the fix! I see there are other occurrences of get_host_access in the DFT and SPARSE tests. Are you planning to also fix them? It could make sense to fix them all in the same PR. I can trigger the internal CI for testing if it's easier.

@JackAKirk
Copy link
Contributor Author

Thanks for the fix! I see there are other occurrences of get_host_access in the DFT and SPARSE tests. Are you planning to also fix them? It could make sense to fix them all in the same PR. I can trigger the internal CI for testing if it's easier.

Apologies, somehow my checkout didn't pull those folders. I've fixed them too now.

@JackAKirk JackAKirk changed the title [BLAS] Remove .template from get_host_access to fix build [BLAS][DFT][SPARSE][TESTS] Remove .template from get_host_access to fix build Jul 12, 2024
@Rbiessy Rbiessy requested review from a team July 12, 2024 13:30
Copy link
Contributor

@andrewtbarker andrewtbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Copy link
Contributor

@gajanan-choudhary gajanan-choudhary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rbiessy
Copy link
Contributor

Rbiessy commented Jul 16, 2024

Merging now as suggested in my email.

@Rbiessy Rbiessy merged commit b4955ca into oneapi-src:develop Jul 16, 2024
6 checks passed
normallytangent pushed a commit to normallytangent/oneMKL that referenced this pull request Aug 6, 2024
… fix build (oneapi-src#534)

Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants