[BLAS][portBLAS] Update interface call for rotmg for portBLAS backend #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to internal changes in portBLAS the copies are not necessary anymore
|
Looks good to me!
|
pgorlani
approved these changes
Aug 22, 2024
Rbiessy
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the dependencies on copy event isn't always respected with OpenCL on CPU devices, this cause random failure with this operator.
To reproduce the failure, run
RotmgUsmoperator in a loop using OpenCL CPU portBLAS backend, it will eventually fail, it generally takes less that 10 iterations.Due to internal changes in portBLAS the copies are not necessary anymore.
Possible related issue intel/llvm#14623
Checklist
All Submissions
Do all unit tests pass locally? Attach a log.
rotmg_amd_log.txt
rotmg_cpu_log.txt
rotmg_nvidia_log.txt
rotmg_pvc_log.txt
Have you formatted the code using clang-format?
Bug fixes
GitHub issue or in this PR)?