Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Having the user manage LD_LIBRARY_PATH is sub-optimal. It is mentioned three times in the docs, which suggest it is a common issue. By setting the
RUNPATH
on the loader library we can makedlopen
automagically find the right libraries.As a downside, we won't be able to point the loader to another oneMKL installation. I'd consider it more of an upside since it prevents accidentally mixing up two versions, but perhaps someone was relying on it?
Only tested on Linux, but official oneAPI plugins only support Linux, so 🤷
Checklist
All Submissions
New interfaces
it was accepted? # (RFC)
New features
Bug fixes
GitHub issue or in this PR)?