[DRAFT] Add generic device support to dft domain through portFFT #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* oneMKL Interfaces currently only supports known targets: Intel CPU/GPU, AMD GPU, Nvidia GPU * This PR: * Enables a new generic target * Enables the generic target to use the portBLAS backend * Adds documentation
possible devices. This commit remove the option ENABLE_GENERIC_DEVICE and instead add generic_device to the backends_table. The check for unsupported_device exception is moved to table_initializer and to keep it as informative as it is, it is required a change to the function_tables operator[]. This change allows to use portBLAS (and in a possible future) all "port" libraries with any device supported.
This patch enables the possibility to run tests with generic_device for devices that have an OpenCL backend.
Moved pragma and simplified if-statement to increase code readability
Rbiessy
reviewed
Sep 9, 2024
Comment on lines
+237
to
+241
| For generic SYCL devices, only portBLAS and portFFT backend are enabled. The user must | ||
| set the appropriate ``-fsycl-targets`` for their device, and also any | ||
| other option required for performance. See | ||
| `Building for portBLAS`_ and `Building for portFFT`_. Extensive testing is strongly advised for these | ||
| unsupported configurations. |
There was a problem hiding this comment.
Can you reformat the paragraph to break the lines at 80 columns? The rewrap extension is great for that if you use VS Code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the continuation of PR #566 and it is based on it.
It adds generic devices support by enabling portFFT and generic device the same way it is done for portBLAS.
Checklist
All Submissions
Following logs show that all domains still work properly:
portfft_log.txt
arc_blas_log.txt
cufft_log.txt
arc_lapack_log.txt
arc_rng_log.txt
New features
Have you provided motivation for adding a new feature?
Same reason added to Add generic device and initial support in portBLAS #566
Have you added relevant tests?
Generic device doesn't require new tests