[RNG] Updated Device API #574
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMartyan
reviewed
Sep 25, 2024
| @@ -56,7 +56,7 @@ constexpr sycl::vec<std::uint64_t, VecSize> select_vector_a_mcg31m1() { | |||
| // hipSYCL (AdaptiveCpp) doesn't support constexpr sycl::vec constructor | |||
| // that's why in case of hipSYCL backend sycl::vec is created as a local variable | |||
| #ifndef __HIPSYCL__ | |||
| template <std::int32_t VecSize> | |||
| template <std::uint64_t VecSize> | |||
There was a problem hiding this comment.
Could you please explain why change length of vecsize?
| uniform() : uniform(static_cast<Type>(0.0f), static_cast<Type>(1.0f)) {} | ||
| uniform() | ||
| : uniform(static_cast<Type>(0.0f), | ||
| std::is_integral<Type>::value |
There was a problem hiding this comment.
Do we need to add similar if for 64 bit integers here similar to device/distributions/hpp ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added following distributions:
betagamma.Added support of
int64_t,uint64_tforuniform.Added support of
int8_t,uint8_t,int16_t,uint16_tforbernoulli.Checklist
All Submissions
New interfaces
it was accepted? # (RFC)
v1.4-provisional-rev-1
New features