Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNG] Updated Device API #574

Merged
merged 14 commits into from
Oct 1, 2024
Merged

[RNG] Updated Device API #574

merged 14 commits into from
Oct 1, 2024

Conversation

andreyfe1
Copy link
Contributor

@andreyfe1 andreyfe1 commented Sep 25, 2024 •
edited
Loading

Description

Added following distributions:

  • beta
  • gamma.

Added support of int64_t, uint64_t for uniform.
Added support of int8_t, uint8_t, int16_t, uint16_t for bernoulli.

Checklist

All Submissions

  • Do all unit tests pass locally? Attach a log.
  • Have you formatted the code using clang-format?

New interfaces

New features

  • Have you provided motivation for adding a new feature?
  • Have you added relevant tests?

iMartyan
iMartyan reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@iMartyan iMartyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also expand tests for new types for uniform and Bernoulli distributions

include/oneapi/mkl/rng/device/detail/mcg31m1_impl.hpp Show resolved Hide resolved
include/oneapi/mkl/rng/device/detail/uniform_impl.hpp Outdated Show resolved Hide resolved
include/oneapi/mkl/rng/distributions.hpp Outdated Show resolved Hide resolved
iMartyan
iMartyan approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@iMartyan iMartyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Thanks!

aelizaro
aelizaro approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@aelizaro aelizaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@andreyfe1 andreyfe1 merged commit b2324f1 into oneapi-src:develop Oct 1, 2024
6 checks passed
@andreyfe1 andreyfe1 deleted the rng_device_api_sync branch October 1, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rbiessy Rbiessy Rbiessy left review comments

@iMartyan iMartyan iMartyan approved these changes

@aelizaro aelizaro aelizaro approved these changes

@egrabovskaya egrabovskaya Awaiting requested review from egrabovskaya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreyfe1 @Rbiessy @aelizaro @iMartyan