Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARSE] Turn matrix_view into an aggregate #608

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[SPARSE] Turn matrix_view into an aggregate #608

wants to merge 1 commit into from

Conversation

pgorlani
Copy link
Contributor

Description

This patch turns sparse::matrix_view into an aggregate having member initializers.

Fixes uxlfoundation/oneAPI-spec#578

Checklist

All Submissions

@pgorlani pgorlani requested a review from a team as a code owner October 30, 2024 16:16
Rbiessy
Rbiessy reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@Rbiessy Rbiessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Paolo, this is a nice solution. @gajanan-choudhary if you are fine with this approach we will also put ut a spec PR for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rbiessy Rbiessy Rbiessy left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[oneMKL][Sparse BLAS] Missing constructor for oneapi::mkl::sparse::matrix_view
2 participants
@pgorlani @Rbiessy