Merge pull request #1934 from yingcong-wu/yc/0806-exclude-shadow-from…

…-coredump [DeviceSanitizer] Exclude shadow memory from coredump file for CPU device.
oneapi-src · Sep 19, 2024 · 1851492 · 1851492
2 parents 2af159d + d619bcd
commit 1851492
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/source/loader/layers/sanitizer/asan_shadow_setup.cpp b/source/loader/layers/sanitizer/asan_shadow_setup.cpp
@@ -29,6 +29,7 @@ ur_result_t SetupShadowMemory(uptr &ShadowBegin, uptr &ShadowEnd) {
  if (SHADOW_BEGIN == 0) {
  return UR_RESULT_ERROR_OUT_OF_HOST_MEMORY;
  }
+ DontCoredumpRange(SHADOW_BEGIN, SHADOW_SIZE);
  SHADOW_END = SHADOW_BEGIN + SHADOW_SIZE;
  IsShadowMemInited = true;
  return UR_RESULT_SUCCESS;

diff --git a/source/loader/layers/sanitizer/common.hpp b/source/loader/layers/sanitizer/common.hpp
@@ -157,6 +157,7 @@ bool IsInASanContext();
 
 uptr MmapNoReserve(uptr Addr, uptr Size);
 bool Munmap(uptr Addr, uptr Size);
+bool DontCoredumpRange(uptr Addr, uptr Size);
 
 void *GetMemFunctionPointer(const char *);
 

diff --git a/source/loader/layers/sanitizer/linux/sanitizer_utils.cpp b/source/loader/layers/sanitizer/linux/sanitizer_utils.cpp
@@ -37,6 +37,12 @@ uptr MmapNoReserve(uptr Addr, uptr Size) {
 
 bool Munmap(uptr Addr, uptr Size) { return munmap((void *)Addr, Size) == 0; }
 
+bool DontCoredumpRange(uptr Addr, uptr Size) {
+ Size = RoundUpTo(Size, EXEC_PAGESIZE);
+ Addr = RoundDownTo(Addr, EXEC_PAGESIZE);
+ return madvise((void *)Addr, Size, MADV_DONTDUMP) == 0;
+}
+
 void *GetMemFunctionPointer(const char *FuncName) {
  void *handle = dlopen(LIBC_SO, RTLD_LAZY | RTLD_NOLOAD);
  if (!handle) {