Skip to content

Commit

Permalink
Wrap native adapter calls inside UR_CHECK_ERROR macro and wrap value …
Browse files Browse the repository at this point in the history 
…checks with an assert instead of returning a generic UR error.
  • Loading branch information
@martygrant
martygrant committed Dec 6, 2023
1 parent 8b7081e commit 3f1e05d
Show file tree
Hide file tree
Showing 3 changed files with 76 additions and 220 deletions.
138 changes: 36 additions & 102 deletions source/adapters/cuda/device.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
UR_CHECK_ERROR(cuDeviceGetAttribute(
&ComputeUnits, CU_DEVICE_ATTRIBUTE_MULTIPROCESSOR_COUNT,
hDevice->get()));
if (ComputeUnits < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(ComputeUnits >= 0);
return ReturnValue(static_cast<uint32_t>(ComputeUnits));
}
case UR_DEVICE_INFO_MAX_WORK_ITEM_DIMENSIONS: {
Expand All @@ -75,21 +73,15 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
int MaxX = 0, MaxY = 0, MaxZ = 0;
UR_CHECK_ERROR(cuDeviceGetAttribute(
&MaxX, CU_DEVICE_ATTRIBUTE_MAX_BLOCK_DIM_X, hDevice->get()));
if (MaxX < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(MaxX > 0);

UR_CHECK_ERROR(cuDeviceGetAttribute(
&MaxY, CU_DEVICE_ATTRIBUTE_MAX_BLOCK_DIM_Y, hDevice->get()));
if (MaxY < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(MaxY > 0);

UR_CHECK_ERROR(cuDeviceGetAttribute(
&MaxZ, CU_DEVICE_ATTRIBUTE_MAX_BLOCK_DIM_Z, hDevice->get()));
if (MaxZ < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(MaxZ > 0);

ReturnSizes.Sizes[0] = size_t(MaxX);
ReturnSizes.Sizes[1] = size_t(MaxY);
Expand All @@ -104,21 +96,15 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
int MaxX = 0, MaxY = 0, MaxZ = 0;
UR_CHECK_ERROR(cuDeviceGetAttribute(
&MaxX, CU_DEVICE_ATTRIBUTE_MAX_GRID_DIM_X, hDevice->get()));
if (MaxX < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(MaxX > 0);

UR_CHECK_ERROR(cuDeviceGetAttribute(
&MaxY, CU_DEVICE_ATTRIBUTE_MAX_GRID_DIM_Y, hDevice->get()));
if (MaxY < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(MaxY > 0);

UR_CHECK_ERROR(cuDeviceGetAttribute(
&MaxZ, CU_DEVICE_ATTRIBUTE_MAX_GRID_DIM_Z, hDevice->get()));
if (MaxZ < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(MaxZ > 0);

ReturnSizes.Sizes[0] = size_t(MaxX);
ReturnSizes.Sizes[1] = size_t(MaxY);
Expand All @@ -131,10 +117,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
UR_CHECK_ERROR(cuDeviceGetAttribute(
&MaxWorkGroupSize, CU_DEVICE_ATTRIBUTE_MAX_THREADS_PER_BLOCK,
hDevice->get()));

if (MaxWorkGroupSize < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(MaxWorkGroupSize > 0);

return ReturnValue(size_t(MaxWorkGroupSize));
}
Expand Down Expand Up @@ -277,9 +260,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
int ClockFreq = 0;
UR_CHECK_ERROR(cuDeviceGetAttribute(
&ClockFreq, CU_DEVICE_ATTRIBUTE_CLOCK_RATE, hDevice->get()));
if (ClockFreq < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(ClockFreq > 0);
return ReturnValue(static_cast<uint32_t>(ClockFreq) / 1000u);
}
case UR_DEVICE_INFO_ADDRESS_BITS: {
Expand Down Expand Up @@ -323,16 +304,12 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
UR_CHECK_ERROR(cuDeviceGetAttribute(
&TexHeight, CU_DEVICE_ATTRIBUTE_MAXIMUM_TEXTURE2D_HEIGHT,
hDevice->get()));
if (TexHeight < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(TexHeight > 0);
int SurfHeight = 0;
UR_CHECK_ERROR(cuDeviceGetAttribute(
&SurfHeight, CU_DEVICE_ATTRIBUTE_MAXIMUM_SURFACE2D_HEIGHT,
hDevice->get()));
if (SurfHeight < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(SurfHeight > 0);

int Min = std::min(TexHeight, SurfHeight);

Expand All @@ -344,16 +321,12 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
UR_CHECK_ERROR(cuDeviceGetAttribute(
&TexWidth, CU_DEVICE_ATTRIBUTE_MAXIMUM_TEXTURE2D_WIDTH,
hDevice->get()));
if (TexWidth < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(TexWidth > 0);
int SurfWidth = 0;
UR_CHECK_ERROR(cuDeviceGetAttribute(
&SurfWidth, CU_DEVICE_ATTRIBUTE_MAXIMUM_SURFACE2D_WIDTH,
hDevice->get()));
if (SurfWidth < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(SurfWidth > 0);

int Min = std::min(TexWidth, SurfWidth);

Expand All @@ -365,16 +338,12 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
UR_CHECK_ERROR(cuDeviceGetAttribute(
&TexHeight, CU_DEVICE_ATTRIBUTE_MAXIMUM_TEXTURE3D_HEIGHT,
hDevice->get()));
if (TexHeight < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(TexHeight > 0);
int SurfHeight = 0;
UR_CHECK_ERROR(cuDeviceGetAttribute(
&SurfHeight, CU_DEVICE_ATTRIBUTE_MAXIMUM_SURFACE3D_HEIGHT,
hDevice->get()));
if (SurfHeight < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(SurfHeight > 0);

int Min = std::min(TexHeight, SurfHeight);

Expand All @@ -386,16 +355,12 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
UR_CHECK_ERROR(cuDeviceGetAttribute(
&TexWidth, CU_DEVICE_ATTRIBUTE_MAXIMUM_TEXTURE3D_WIDTH,
hDevice->get()));
if (TexWidth < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(TexWidth > 0);
int SurfWidth = 0;
UR_CHECK_ERROR(cuDeviceGetAttribute(
&SurfWidth, CU_DEVICE_ATTRIBUTE_MAXIMUM_SURFACE3D_WIDTH,
hDevice->get()));
if (SurfWidth < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(SurfWidth > 0);

int Min = std::min(TexWidth, SurfWidth);

Expand All @@ -407,16 +372,12 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
UR_CHECK_ERROR(cuDeviceGetAttribute(
&TexDepth, CU_DEVICE_ATTRIBUTE_MAXIMUM_TEXTURE3D_DEPTH,
hDevice->get()));
if (TexDepth < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(TexDepth > 0);
int SurfDepth = 0;
UR_CHECK_ERROR(cuDeviceGetAttribute(
&SurfDepth, CU_DEVICE_ATTRIBUTE_MAXIMUM_SURFACE3D_DEPTH,
hDevice->get()));
if (SurfDepth < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(SurfDepth > 0);

int Min = std::min(TexDepth, SurfDepth);

Expand All @@ -428,16 +389,12 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
UR_CHECK_ERROR(cuDeviceGetAttribute(
&TexWidth, CU_DEVICE_ATTRIBUTE_MAXIMUM_TEXTURE1D_WIDTH,
hDevice->get()));
if (TexWidth < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(TexWidth > 0);
int SurfWidth = 0;
UR_CHECK_ERROR(cuDeviceGetAttribute(
&SurfWidth, CU_DEVICE_ATTRIBUTE_MAXIMUM_SURFACE1D_WIDTH,
hDevice->get()));
if (SurfWidth < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(SurfWidth > 0);

int Min = std::min(TexWidth, SurfWidth);

Expand Down Expand Up @@ -506,28 +463,22 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
int CacheSize = 0;
UR_CHECK_ERROR(cuDeviceGetAttribute(
&CacheSize, CU_DEVICE_ATTRIBUTE_L2_CACHE_SIZE, hDevice->get()));
if (CacheSize < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(CacheSize > 0);
// The L2 cache is global to the GPU.
return ReturnValue(static_cast<uint64_t>(CacheSize));
}
case UR_DEVICE_INFO_GLOBAL_MEM_SIZE: {
size_t Bytes = 0;
// Runtime API has easy access to this value, driver API info is scarse.
if (cuDeviceTotalMem(&Bytes, hDevice->get()) != CUDA_SUCCESS) {
return UR_RESULT_ERROR_INVALID_OPERATION;
}
UR_CHECK_ERROR(cuDeviceTotalMem(&Bytes, hDevice->get()));
return ReturnValue(uint64_t{Bytes});
}
case UR_DEVICE_INFO_MAX_CONSTANT_BUFFER_SIZE: {
int ConstantMemory = 0;
UR_CHECK_ERROR(cuDeviceGetAttribute(
&ConstantMemory, CU_DEVICE_ATTRIBUTE_TOTAL_CONSTANT_MEMORY,
hDevice->get()));
if (ConstantMemory < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(ConstantMemory > 0);

return ReturnValue(static_cast<uint64_t>(ConstantMemory));
}
Expand Down Expand Up @@ -557,9 +508,8 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
UR_CHECK_ERROR(cuDeviceGetAttribute(
&ECCEnabled, CU_DEVICE_ATTRIBUTE_ECC_ENABLED, hDevice->get()));

if ((ECCEnabled != 0) || (ECCEnabled != 1)) {
return UR_RESULT_ERROR_INVALID_OPERATION;
}
assert(ECCEnabled == 0 || ECCEnabled == 1);

auto Result = static_cast<bool>(ECCEnabled);
return ReturnValue(Result);
}
Expand All @@ -568,9 +518,8 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
UR_CHECK_ERROR(cuDeviceGetAttribute(
&IsIntegrated, CU_DEVICE_ATTRIBUTE_INTEGRATED, hDevice->get()));

if ((IsIntegrated != 0) || (IsIntegrated != 1)) {
return UR_RESULT_ERROR_INVALID_OPERATION;
}
assert(IsIntegrated == 0 || IsIntegrated == 1);

auto result = static_cast<bool>(IsIntegrated);
return ReturnValue(result);
}
Expand Down Expand Up @@ -851,27 +800,22 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
case UR_DEVICE_INFO_GLOBAL_MEM_FREE: {
size_t FreeMemory = 0;
size_t TotalMemory = 0;
assert(cuMemGetInfo(&FreeMemory, &TotalMemory) != CUDA_SUCCESS &&
"failed cuMemGetInfo() API.");
UR_CHECK_ERROR(cuMemGetInfo(&FreeMemory, &TotalMemory));
return ReturnValue(FreeMemory);
}
case UR_DEVICE_INFO_MEMORY_CLOCK_RATE: {
int Value = 0;
UR_CHECK_ERROR(cuDeviceGetAttribute(
&Value, CU_DEVICE_ATTRIBUTE_MEMORY_CLOCK_RATE, hDevice->get()));
if (Value < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(Value > 0);
// Convert kilohertz to megahertz when returning.
return ReturnValue(Value / 1000);
}
case UR_DEVICE_INFO_MEMORY_BUS_WIDTH: {
int Value = 0;
UR_CHECK_ERROR(cuDeviceGetAttribute(
&Value, CU_DEVICE_ATTRIBUTE_GLOBAL_MEMORY_BUS_WIDTH, hDevice->get()));
if (Value < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(Value > 0);
return ReturnValue(Value);
}
case UR_DEVICE_INFO_MAX_COMPUTE_QUEUE_INDICES: {
Expand Down Expand Up @@ -959,21 +903,15 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
int Value = 0;
UR_CHECK_ERROR(cuDeviceGetAttribute(
&Value, CU_DEVICE_ATTRIBUTE_PCI_DEVICE_ID, hDevice->get()));
if (Value < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(Value > 0);
return ReturnValue(Value);
}
case UR_DEVICE_INFO_UUID: {
CUuuid UUID;
#if (CUDA_VERSION >= 11040)
if (cuDeviceGetUuid_v2(&UUID, hDevice->get()) != CUDA_SUCCESS) {
return UR_RESULT_ERROR_INVALID_DEVICE;
}
UR_CHECK_ERROR(cuDeviceGetUuid_v2(&UUID, hDevice->get()));
#else
if (cuDeviceGetUuid(&UUID, hDevice->get()) != CUDA_SUCCESS) {
return UR_RESULT_ERROR_INVALID_DEVICE;
}
UR_CHECK_ERROR(cuDeviceGetUuid(&UUID, hDevice->get()));
#endif
std::array<unsigned char, 16> Name;
std::copy(UUID.bytes, UUID.bytes + 16, Name.begin());
Expand Down Expand Up @@ -1052,9 +990,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
&MaxRegisters, CU_DEVICE_ATTRIBUTE_MAX_REGISTERS_PER_BLOCK,
hDevice->get()));

if (MaxRegisters < 0) {
return UR_RESULT_ERROR_INVALID_SIZE;
}
assert(MaxRegisters > 0);

return ReturnValue(static_cast<uint32_t>(MaxRegisters));
}
Expand All @@ -1068,9 +1004,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
UR_CHECK_ERROR(
cuDeviceGetPCIBusId(AddressBuffer, AddressBufferSize, hDevice->get()));
// CUDA API (8.x - 12.1) guarantees 12 bytes + \0 are written
if (strnlen(AddressBuffer, AddressBufferSize) != 12) {
return UR_RESULT_ERROR_INVALID_OPERATION;
}
assert(strnlen(AddressBuffer, AddressBufferSize) != 12);
return ReturnValue(AddressBuffer,
strnlen(AddressBuffer, AddressBufferSize - 1) + 1);
}
Expand Down
Loading

0 comments on commit 3f1e05d

Please sign in to comment.