Merge pull request #2108 from pbalcer/fix-perf-tracing-logs

fix perf regression in tracing layer
oneapi-src · Sep 20, 2024 · 7384e2d · 7384e2d
2 parents ed85c3e + a32549b
commit 7384e2d
Show file tree

Hide file tree

Showing 3 changed files with 1,732 additions and 960 deletions.
diff --git a/scripts/templates/trcddi.cpp.mako b/scripts/templates/trcddi.cpp.mako
@@ -45,15 +45,19 @@ namespace ur_tracing_layer
  ${th.make_pfncb_param_type(n, tags, obj)} params = { &${",&".join(th.make_param_lines(n, tags, obj, format=["name"]))} };
  uint64_t instance = getContext()->notify_begin(${th.make_func_etor(n, tags, obj)}, "${th.make_func_name(n, tags, obj)}", &params);
 
- getContext()->logger.info("---> ${th.make_func_name(n, tags, obj)}");
+ auto &logger = getContext()->logger;
+
+ logger.info("---> ${th.make_func_name(n, tags, obj)}");
 
  ${x}_result_t result = ${th.make_pfn_name(n, tags, obj)}( ${", ".join(th.make_param_lines(n, tags, obj, format=["name"]))} );
 
  getContext()->notify_end(${th.make_func_etor(n, tags, obj)}, "${th.make_func_name(n, tags, obj)}", &params, &result, instance);
 
- std::ostringstream args_str;
- ur::extras::printFunctionParams(args_str, ${th.make_func_etor(n, tags, obj)}, &params);
- getContext()->logger.info("({}) -> {};\n", args_str.str(), result);
+ if (logger.getLevel() <= logger::Level::INFO) {
+ std::ostringstream args_str;
+ ur::extras::printFunctionParams(args_str, ${th.make_func_etor(n, tags, obj)}, &params);
+ logger.info("({}) -> {};\n", args_str.str(), result);
+ }
 
  return result;
  }

diff --git a/source/common/logger/ur_logger_details.hpp b/source/common/logger/ur_logger_details.hpp
@@ -30,6 +30,8 @@ class Logger {
 
  void setLevel(logger::Level level) { this->level = level; }
 
+ logger::Level getLevel() { return this->level; }
+
  void setFlushLevel(logger::Level level) {
  if (sink) {
  this->sink->setFlushLevel(level);