[CTS] Add UR_SYCL_LIBRARY_DIR CMake variable #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbalcer
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Might be useful to also update the CI workflow:
https://github.com/oneapi-src/unified-runtime/blob/adapters/.github/workflows/cmake.yml#L203
kbenzie
force-pushed
the
benie/test-conformance-sycl-library-dir
branch
2 times, most recently
from
5990368
to
f3042a0
Compare
callumfare
approved these changes
Nov 6, 2023
The CTS is already dependant on the DPC++ compiler to generate programs inputs for the program, kernel, and enqueue test suites specified via the `UR_DPCXX` CMake variable. If the DPC++ compiler is not installed on the system the executables it outputs will likely fail to find the SYCL runtime library when executed, breaking the generation of CTS program inputs. The patch introduces the `UR_SYCL_LIBRARY_DIR` CMake variable enabling the user to specify the path to the SYCL runtime library for use when generating CTS program inputs.
kbenzie
force-pushed
the
benie/test-conformance-sycl-library-dir
branch
from
f3042a0
to
b01beb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CTS is already dependant on the DPC++ compiler to generate programs inputs for the program, kernel, and enqueue test suites specified via the
UR_DPCXXCMake variable. If the DPC++ compiler is not installed on the system the executables it outputs will likely fail to find the SYCL runtime library when executed, breaking the generation of CTS program inputs. The patch introduces theUR_SYCL_LIBRARY_DIRCMake variable enabling the user to specify the path to the SYCL runtime library for use when generating CTS program inputs.