[SYCL][HIP] Implement mem_advise for HIP

[GeorgeWeb]

Adds initial implementation for mem_advise to the HIP adapter.

[GeorgeWeb]

Related intel/llvm PR: intel/llvm#10697

[JackAKirk]

I just remembered that this is not consistent with the change to the spec made here: https://github.com/oneapi-src/unified-runtime/pull/854/files

See how the cuda behaviour has been changed here: #989

I think the behaviour should at least be consistent across adapters.

[GeorgeWeb]

I just remembered that this is not consistent with the change to the spec made here: https://github.com/oneapi-src/unified-runtime/pull/854/files

See how the cuda behaviour has been changed here: #989

I think the behaviour should at least be consistent across adapters.

@JackAKirk Good catch. This PR was moved from intel/llvm where it was open for a while so I kinda missed the UR-spec related changes. Will update, thanks for spotting this.

[JackAKirk]

I just remembered that this is not consistent with the change to the spec made here: https://github.com/oneapi-src/unified-runtime/pull/854/files
See how the cuda behaviour has been changed here: #989
I think the behaviour should at least be consistent across adapters.

@JackAKirk Good catch. This PR was moved from intel/llvm where it was open for a while so I kinda missed the UR-spec related changes. Will update, thanks for spotting this.

no worries, otherwise LGTM.

[fabiomestre]

I have updated the target branch of this PR from the adapters branch to the main branch.
Development in UR is moving back to main. The adapters branch will soon be deleted.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e69ed21) 15.70% compared to head (62d0934) 15.70%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1027   +/-   ##
=======================================
  Coverage   15.70%   15.70%           
=======================================
  Files         223      223           
  Lines       31518    31518           
  Branches     3556     3556           
=======================================
  Hits         4951     4951           
  Misses      26516    26516           
  Partials       51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kbenzie]

@GeorgeWeb FYI I rebased this on top of main to clean up the history aiming to merge this next.