Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][UR][L0] Distinguish min/max calls from macros #1045

Merged
merged 1 commit into from
Nov 8, 2023
Merged

[SYCL][UR][L0] Distinguish min/max calls from macros #1045

merged 1 commit into from
Nov 8, 2023
+12 −12

Conversation

kswiecicki
Copy link
Contributor

This fixes collision between min/max functions and macros on Windows.

@kswiecicki kswiecicki requested review from a team as code owners November 7, 2023 12:08
@kswiecicki kswiecicki mentioned this pull request Nov 7, 2023
Open
EwanC
EwanC approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM based on discussions in #905 (comment)

lukaszstolarczuk
lukaszstolarczuk reviewed Nov 7, 2023
View reviewed changes
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@igchor igchor merged commit 2f44433 into oneapi-src:adapters Nov 8, 2023
40 of 48 checks passed
kbenzie added a commit to kbenzie/unified-runtime that referenced this pull request Nov 9, 2023
@kbenzie
Revert "Merge pull request oneapi-src#1045 from kswiecicki/windows-mi…
63f48aa 
…n-max-fix"

This reverts commit 2f44433, reversing
changes made to ec7982b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk left review comments

@lplewa lplewa lplewa approved these changes

@jandres742 jandres742 jandres742 approved these changes

@EwanC EwanC EwanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kswiecicki @EwanC @jandres742 @lplewa @lukaszstolarczuk @igchor