[OpenCL] Fix memory leak and coverity issue with struct-to-array casts #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongreig
approved these changes
Nov 7, 2023
martygrant
approved these changes
Nov 7, 2023
|
LLVM PR for testing: intel/llvm#11806 |
kbenzie
approved these changes
Nov 7, 2023
callumfare
force-pushed
the
opencl_fix_urMemBufferCreate_leak
branch
2 times, most recently
from
75e0679
to
2ed872d
Compare
callumfare
force-pushed
the
opencl_fix_urMemBufferCreate_leak
branch
from
2ed872d
to
46cf37f
Compare
Also fix a similar issue coverity had with CreateProgramWithBinary which was passing array pointers straight through to the cl entry point by putting these params in local const arrays.
callumfare
changed the title
urMemBufferCreate
steffenlarsen
pushed a commit
to intel/llvm
that referenced
this pull request
Nov 21, 2023
Includes UR changes from [ [OpenCL] Fix memory leak and coverity issue with struct-to-array casts #1048 ](oneapi-src/unified-runtime#1048).
callumfare
added a commit
to kbenzie/llvm
that referenced
this pull request
Dec 18, 2023
Includes UR changes from [ [OpenCL] Fix memory leak and coverity issue with struct-to-array casts intel#1048 ](oneapi-src/unified-runtime#1048).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix memory leak reported in #1034
This bug was introduced when porting the original OpenCL plugin to UR. If the
clCreateBufferWithPropertiesextension function exists, we should return even if it succeeds rather than continuing to the fallback call toclCreateBuffer.Also add fixes from #1054: