[OpenCL] Fetch headers/icd-loader by default #1051
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces the follow CMake options: * `UR_OPENCL_INCLUDE_DIR` - directory containing the OpenCL Headers * `UR_OPENCL_ICD_LOADER_LIBRARY` - path of the OpenCL ICD Loader library In the event that `UR_OPENCL_INCLUDE_DIR` is not specified, clone [KhronosGroup/OpenCL-Headers](https://github.com/KhronosGroup/OpenCL-Headers.git). In the event that `UR_OPENCL_ICD_LOADER_LIBRARY` is not specified, first inspect the system with `find_package(OpenCL 3.0)` and use that if found. Otherwise, clone [KhronosGroup/OpenCL-ICD-Loader](https://github.com/KhronosGroup/OpenCL-ICD-Loader.git).
aarongreig
approved these changes
Nov 9, 2023
fabiomestre
approved these changes
Nov 16, 2023
|
This PR will necessitate changing how intel/llvm sets UR_OPENCL_ICD_LOADER_LIBRARY to a cache varaible. |
|
Closing as this was included in #993. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the follow CMake options:
UR_OPENCL_INCLUDE_DIR- directory containing the OpenCL HeadersUR_OPENCL_ICD_LOADER_LIBRARY- path of the OpenCL ICD Loader libraryIn the event that
UR_OPENCL_INCLUDE_DIRis not specified, clone KhronosGroup/OpenCL-Headers.In the event that
UR_OPENCL_ICD_LOADER_LIBRARYis not specified, first inspect the system withfind_package(OpenCL 3.0)and use that if found. Otherwise, clone KhronosGroup/OpenCL-ICD-Loader.