Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenCL] Fetch headers/icd-loader by default #1051

Closed

Conversation

kbenzie
Copy link
Contributor

@kbenzie kbenzie commented Nov 8, 2023

Introduces the follow CMake options:

  • UR_OPENCL_INCLUDE_DIR - directory containing the OpenCL Headers
  • UR_OPENCL_ICD_LOADER_LIBRARY - path of the OpenCL ICD Loader library

In the event that UR_OPENCL_INCLUDE_DIR is not specified, clone KhronosGroup/OpenCL-Headers.

In the event that UR_OPENCL_ICD_LOADER_LIBRARY is not specified, first inspect the system with find_package(OpenCL 3.0) and use that if found. Otherwise, clone KhronosGroup/OpenCL-ICD-Loader.

Introduces the follow CMake options:

* `UR_OPENCL_INCLUDE_DIR` - directory containing the OpenCL Headers
* `UR_OPENCL_ICD_LOADER_LIBRARY` - path of the OpenCL ICD Loader library

In the event that `UR_OPENCL_INCLUDE_DIR` is not specified, clone
[KhronosGroup/OpenCL-Headers](https://github.com/KhronosGroup/OpenCL-Headers.git).

In the event that `UR_OPENCL_ICD_LOADER_LIBRARY` is not specified, first
inspect the system with `find_package(OpenCL 3.0)` and use that if
found. Otherwise, clone
[KhronosGroup/OpenCL-ICD-Loader](https://github.com/KhronosGroup/OpenCL-ICD-Loader.git).
@kbenzie kbenzie requested a review from a team as a code owner November 8, 2023 14:45
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kbenzie
Copy link
Contributor Author

kbenzie commented Nov 16, 2023

This PR will necessitate changing how intel/llvm sets UR_OPENCL_ICD_LOADER_LIBRARY to a cache varaible.

@kbenzie
Copy link
Contributor Author

kbenzie commented Nov 29, 2023

Closing as this was included in #993.

@kbenzie kbenzie closed this Nov 29, 2023
@kbenzie kbenzie deleted the benie/opencl-fetch-headers branch June 11, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants