[UR][L0] Upgrade L0 loader to v1.15.1 #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandres742
force-pushed
the
updateL0loader
branch
3 times, most recently
from
793ff7c
to
068c324
Compare
pbalcer
approved these changes
Nov 13, 2023
|
To be merged once intel/llvm#11844 is approved, since we need to update the loader in lock-step way in the UR and in the intel-llvm. |
pbalcer
reviewed
Nov 14, 2023
jandres742
force-pushed
the
updateL0loader
branch
7 times, most recently
from
1264873
to
87f560e
Compare
|
Considering headers are backwards compatible, we can merge this ahead of the changes in intel/llvm. @kbenzie : please merge when possible. |
nrspruit
reviewed
Nov 27, 2023
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unused-parameter") | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-c++98-compat-extra-semi") | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unknown-warning-option") | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-non-virtual-dtor") |
There was a problem hiding this comment.
As of oneapi-src/level-zero@cfc05b0 you should not need at least non-virtual-dtor
There was a problem hiding this comment.
thanks @nrspruit . Seems like it is not needed, based on my local testing. Removed it.
jandres742
force-pushed
the
updateL0loader
branch
from
87f560e
to
e662dfb
Compare
nrspruit
approved these changes
Nov 28, 2023
|
I have updated the target branch of this PR from the |
|
@kbenzie : please merge this when possible. |
13 tasks
kbenzie
force-pushed
the
updateL0loader
branch
from
e662dfb
to
e4b0a49
Compare
nrspruit
approved these changes
Dec 14, 2023
added 2 commits
December 14, 2023 16:05
This to use latest features present in L0 spec. Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
kbenzie
force-pushed
the
updateL0loader
branch
from
e4b0a49
to
9fc2c2e
Compare
kbenzie
added a commit
to kbenzie/unified-runtime
that referenced
this pull request
Dec 14, 2023
[UR][L0] Upgrade L0 loader to v1.15.1
kbenzie
added a commit
to kbenzie/unified-runtime
that referenced
this pull request
Dec 15, 2023
[UR][L0] Upgrade L0 loader to v1.15.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM testing: intel/llvm#11844