Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CUDA] Combined CTX Fixes #1065

Closed
wants to merge 3 commits into from
Closed

[CUDA] Combined CTX Fixes #1065

wants to merge 3 commits into from

Conversation

fabiomestre
Copy link
Contributor

@fabiomestre fabiomestre commented Nov 10, 2023 •
edited
Loading

@fabiomestre
[CUDA] Update hint functions to only return warnings
b26be7f 
- The UR spec was recently changed to guarantee that hint entryponts
never return errors. This commit changes the CUDA adapter to be
conformant with this change.
- This commit also changes the type of PointerRangeSize which
 was causing a stack corruption.
@fabiomestre
[CUDA] Add support for binary type query
b47a36a 
CUDA does not make a distinction between binaryTypes (it treats PTX and binaries using the same entrypoints).

However, for UR, by definition:

* urProgramCompile should set the binary type to UR_PROGRAM_BINARY_TYPE_COMPILED_OBJECT
* urProgramBuild / urProgramLink should set it to UR_PROGRAM_BINARY_TYPE_EXECUTABLE.
* urProgramCreateWithBinary should set the binary type to UR_PROGRAM_BINARY_TYPE_COMPILED_OBJECT
@fabiomestre fabiomestre changed the base branch from main to adapters November 10, 2023 13:30
@fabiomestre fabiomestre marked this pull request as ready for review November 10, 2023 14:24
@fabiomestre fabiomestre requested a review from a team as a code owner November 10, 2023 14:24
JackAKirk
JackAKirk approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@JackAKirk JackAKirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sub commits are approved. I think you should still have a short description of them in the title though?

@kbenzie kbenzie changed the title [CUDA] Combined PR's [CUDA] Combined CTX Fixes Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackAKirk JackAKirk JackAKirk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabiomestre @JackAKirk