Remove Python API bindings #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbalcer
reviewed
Nov 14, 2023
There was a problem hiding this comment.
remove the template file as well.
There's also a few python-specific functions/ifs in helper.py.
callumfare
force-pushed
the
callum/remove_py_bindings
branch
from
1de1b9a
to
d97f4df
Compare
pbalcer
approved these changes
Nov 16, 2023
callumfare
force-pushed
the
callum/remove_py_bindings
branch
from
d97f4df
to
22b34ea
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1075 +/- ##
=========================================
+ Coverage 0 15.73% +15.73%
=========================================
Files 0 223 +223
Lines 0 31465 +31465
Branches 0 3556 +3556
=========================================
+ Hits 0 4952 +4952
- Misses 0 26462 +26462
- Partials 0 51 +51 ☔ View full report in Codecov by Sentry. |
omarahmed1111
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
LGTM, just a small note,
I guess we need to also remove python from CI like here
callumfare
force-pushed
the
callum/remove_py_bindings
branch
from
22b34ea
to
642c454
Compare
kbenzie
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the Python bindings for UR. They are unused and just a holdover from the initial port of the scripts/templates used to generate UR.