-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NFC] Add utility function ur_unreachable to simplify code #1124
Conversation
@kbenzie could you please take a look if this PR makes sense? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Native CPU LGTM, thank you
I think there's a missing include in the CUDA file that's attempting to use |
added to both cuda/usm.cpp and hip/usm.cpp. I don't have access to cuda/hip machines to verify. After searching the headers used in hip/usm.cpp, it looks like ur_util.hpp is needed. |
If you could add those includes we can let the CI check if the fix works. Edit: I missed the commit. Seems there still an issue, I can look into this to see what's gone wrong. |
I have updated the target branch of this PR from the |
72b3cc0
to
5accf50
Compare
No description provided.