Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CUDA][HIP][L0][NATIVECPU][OpenCL] Remove usage of die/terminate #1127

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[CUDA][HIP][L0][NATIVECPU][OpenCL] Remove usage of die/terminate #1127

wants to merge 4 commits into from

Commits on Apr 8, 2024

  1. [CUDA][HIP][L0][NATIVECPU][OpenCL] Remove usage of die/terminate thro… 

    …ughout adapters.
    @martygrant
    martygrant committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    c39ee6a View commit details
    Browse the repository at this point in the history

  2. Address feedback - missing breaks in switches, more appropriate error… 

    … codes or replacing original

error message to use an assert from cassert header and some other minor fixes.
    @martygrant
    martygrant committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    272d04e View commit details
    Browse the repository at this point in the history

  3. Wrap native adapter calls inside UR_CHECK_ERROR macro and wrap value … 

    …checks with an assert instead of returning a generic UR error.
    @martygrant
    martygrant committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    1b1279d View commit details
    Browse the repository at this point in the history

  4. Surround UR_CHECK_ERROR calls with a try/catch as they may throw an e… 

    …rror. Format code.
    @martygrant
    martygrant committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    432bfcc View commit details
    Browse the repository at this point in the history