[UR][L0] Make urPlatformGetBackendOption return -ze-opt-level=2 for -O1 and -O2 #1129
Conversation
|
@kbenzie Do you mind approving the CI run for this? Thanks! |
|
thanks @sarnex . could you open a PR in intel/llvm to validate the changes before merging? please see guidelines here https://oneapi-src.github.io/unified-runtime/core/CONTRIB.html#adapter-change-process and a sample here github.com//pull/1099 |
sarnex
changed the title
…O1 and -O2 oneapi-src/unified-runtime#1129 Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
|
changes are looking good. We will wait for llvm testing. |
|
@jandres742 Sorry about that, the contribution guidelines changed since I last worked here and I made the mistake of assuming I didn't need to check again :) The llvm PR CI passed, so we should be good there |
|
I have updated the target branch of this PR from the |
|
Sure, hopefully we can merge this soon, let me know if something is needed from me |
|
@fabiomestre @kbenzie Any ETA on this being merged? Thanks |
We're aiming to clear the ready to merge backlog this week. |
|
@kbenzie Cool thanks for the update |
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
…O1 and -O2 (#12023) oneapi-src/unified-runtime#1129 --------- Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com> Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
IGC only accepts three values for -ze-opt-level, 0, 1 and 2, however dpcpp has at least four options, O0, O1, O2 and O3.
Right now we decided to map O1 and O2 to -ze-opt-level=1, but we have determined that this is not the best for user experience and may defy user expectation, and actually produces worse code than specifying nothing because IGC uses ze-opt-level=2 if nothing is specified.
intel/llvm#12023