Add DEVICE_INFO_GLOBAL_VARIABLE_SUPPORT device info query. #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongreig
force-pushed
the
aaron/deviceGlobalInfo
branch
from
987f0f2
to
5303368
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1145 +/- ##
==========================================
- Coverage 15.74% 15.72% -0.02%
==========================================
Files 223 223
Lines 31466 31494 +28
Branches 3556 3558 +2
==========================================
- Hits 4953 4952 -1
- Misses 26462 26491 +29
Partials 51 51 ☔ View full report in Codecov by Sentry. |
|
I have updated the target branch of this PR from the |
This gates support for the EnqueueDeviceGlobalVariableRead and Write operations. The CTS tests for these now check for support before running, and all adapters report their support correctly.
aarongreig
force-pushed
the
aaron/deviceGlobalInfo
branch
from
5303368
to
a0224b2
Compare
This was referenced Dec 29, 2023
fabiomestre
approved these changes
Jan 1, 2024
nrspruit
approved these changes
Jan 10, 2024
|
friendly ping @oneapi-src/unified-runtime-cuda-write @oneapi-src/unified-runtime-hip-write @npmiller |
|
merged into #1212 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gates support for the EnqueueDeviceGlobalVariableRead and Write operations. The CTS tests for these now check for support before running, and all adapters report their support correctly.
LLVM testing intel/llvm#12264