[NATIVECPU] Handle oneAPI Construction Kit integration in runtime #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have updated the target branch of this PR from the |
Thanks @fabiomestre |
PietroGhg
force-pushed
the
pietro/barriers
branch
from
4581bc4
to
0da76bf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1152 +/- ##
=======================================
Coverage 15.73% 15.74%
=======================================
Files 223 223
Lines 31459 31459
Branches 3542 3542
=======================================
+ Hits 4951 4952 +1
+ Misses 26457 26456 -1
Partials 51 51 ☔ View full report in Codecov by Sentry. |
uwedolinsky
approved these changes
Dec 7, 2023
martygrant
approved these changes
Dec 7, 2023
PietroGhg
force-pushed
the
pietro/barriers
branch
from
0da76bf
to
71e7e38
Compare
sommerlukas
pushed a commit
to intel/llvm
that referenced
this pull request
Jan 25, 2024
This PR adds support to barriers by integrating LLVM passes from the [oneAPI Construction Kit](https://github.com/codeplaysoftware/oneapi-construction-kit). The OCK is fetched via CMake when the Native CPU plug-in is enabled, and can optionally be disabled through the `NATIVE_CPU_USE_OCK` CMake option. When the OCK is available, the `NATIVECPU_USE_OCK` definition is set for the targets defined in `llvm/lib/SYCLLowerIR`. This PR also refactors the pass pipeline for Native CPU, making it so all of passes relevant to Native CPU are run in the `clang` invocation that lowers the IR to the target ISA, this is done to allow correct handling of barriers with functions declared with `SYCL_EXTERNAL`. Unified Runtime PR: oneapi-src/unified-runtime#1152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intel/llvm PR: intel/llvm#11614
With intel/llvm#11614 we start integrating the oneAPI Construction Kit. If the OCK is enabled, it creates the work item loops in the compiler, so it is not necessary to execute the loops in the adapter.