Allow fixtures derived from KernelTest to defer compilation. #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separating the device code compilation from the rest of the setup lets a test query device or platform properties to decide whether it should skip without potentially hitting a compilation error because the kernel being built as part of the setup uses an unsupported feature.
callumfare
approved these changes
Dec 4, 2023
kbenzie
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separating the device code compilation from the rest of the setup lets a test query device or platform properties to decide whether it should skip without potentially hitting a compilation error because the kernel being built as part of the setup uses an unsupported feature.