Merge adapters branch into main #1158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that USM allocation APIs don't return `UR_RESULT_SUCCESS` when an error occurs within `USMAllocationMakeResident`. Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Input and match files were printed only on one error. Now, it will be printed for both places (where this makes sense). This is an extension to commit: be85a49
[UR][Tests] Update match scripts
The E2E test assumes that the device supports priorities (sm_35 or newer).
[UR][HIP] Move HIP adapter sourcer to Unified Runtime
On Windows we may build L0 using ICX , this is to revert changes to check WIN32 instead of MSVC, to fix build failures with ICX on Windows.
[UR][L0][CMake] Disable warning for ICX on Windows
[L0] fix windows cmake scripts
We allow reusing existing pre-built L0 Libs and Headers. However, using LEVEL_ZERO_LIBRARY and LEVEL_ZERO_INCLUDE_DIR directly may leak the path of shared folder. This PR introduces two L0_LIBRARY and L0_INCLUDE_DIR , and copy L0 loader/headers locally to the build to avoid leaking their location on a shared drive.
[UR][L0] Copy prebuilt L0 to avoid leaking shared folder path
Adapter implementations are being moved into the repo we should mirror the code ownership of those implementations. This patch adds a CODEOWNERS file which matches the pre adapter move ownership to be used as a baseline for future changes for each individual adapter.
The new priority parameter hadn't been reflected here so the ownership property was being used as priority and default to `true` which caused crashes.
For kernel fusion support for hip, we need to finalize the kernels using comgr. The patch finalizes tagged binaries during buildProgram before handing it over to the hip runtime. Signed-off-by: Victor Lomuller <victor@codeplay.com>
- Second return has no effect - Checking the same flag twice has no effect
Add CODEOWNERS file
[UR][L0] Propagate errors from `USMAllocationMakeResident`
…elzero-adapter [UR][L0] Fix minor code duplication
The HIP team needs some fixing up currently so use the CUDA team for now.
Add code owners for the CUDA and HIP adapters
…-zero [UR][L0] Add adapter source to codeowners file
Update HIP adapter codeowners to use specific team
[HIP] Ifdef entry point introduced in HIP 5.6
…-l0-clang-cl [GHA] Disable Windows L0 clang-cl job
Add system info in CI workflows run on self-hosted runners
…-changes-into-adapters-third-patch Merge main into adapters branch
[HIP] Adapter PR batch
…pters CMake Flag for building all adapters
…er-refcount-fix [UR] Fix adapter refcount tracking
…erGet [UR] Fix urAdapterGet ignores NumEntries
Separating the device code compilation from the rest of the setup lets a test query device or platform properties to decide whether it should skip without potentially hitting a compilation error because the kernel being built as part of the setup uses an unsupported feature.
Update the `scripts/ctest_parser.py` to work with the adapter branch changes.
…rnelFixtures Allow fixtures derived from KernelTest to defer compilation.
This is accomplished with the various size queries for buffers, images and USM allocations. Since not all adapters have these queries implemented the bounds checking isn't entirely comprehensive on all platforms just yet.
…rser [CTS] Update ctest_parser.py script
[HIP] Hip adapter multi dev ctx
…ckingValidation Add bounds checking for enqueue operations to the validation layer.
|
Gonna close this, should've just used the adapters branch directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull in the adapters branch changes to the main branch in preparation for removal of the adapters branch.