-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tracing param in disjoint_pool_parser #1172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how did nothing catch this? if anything but 0/1/false/true was assigned to this variable, coverity would have complained, no?
4cf9b9e
to
c154302
Compare
Yeah, I would think so, or that there should be a warning here. But for a warning, it seems it would only be generated if we'd use braced initialization. |
The disjoint_pool implementation distinguishes between a few different levels of logging (0-3). The argument should be an int, not bool.
c154302
to
2b42eaa
Compare
Without this change, setting UR_L0_USM_ALLOCATOR_TRACE or SYCL_PI_LEVEL_ZERO_USM_ALLOCATOR_TRACE only had an effect if UR_L0_USM_ALLOCATOR or SYCL_PI_LEVEL_ZERO_USM_ALLOCATOR was also set.
2b42eaa
to
8ee650d
Compare
I just realized there was one more problem. I fixed it in a separate commit. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1172 +/- ##
==========================================
+ Coverage 15.70% 15.74% +0.03%
==========================================
Files 223 223
Lines 31518 31468 -50
Branches 3556 3557 +1
==========================================
+ Hits 4951 4955 +4
+ Misses 26516 26462 -54
Partials 51 51 ☔ View full report in Codecov by Sentry. |
LGTM |
The disjoint_pool implementation distinguishes between a few different levels of logging (0-3). The argument should be an int, not bool.