Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tracing param in disjoint_pool_parser #1172

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

igchor
Copy link
Member

@igchor igchor commented Dec 8, 2023

The disjoint_pool implementation distinguishes between a few different levels of logging (0-3). The argument should be an int, not bool.

@igchor igchor requested review from a team as code owners December 8, 2023 20:33
Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did nothing catch this? if anything but 0/1/false/true was assigned to this variable, coverity would have complained, no?

source/adapters/level_zero/usm.cpp Outdated Show resolved Hide resolved
@igchor
Copy link
Member Author

igchor commented Dec 11, 2023

how did nothing catch this? if anything but 0/1/false/true was assigned to this variable, coverity would have complained, no?

Yeah, I would think so, or that there should be a warning here. But for a warning, it seems it would only be generated if we'd use braced initialization.

The disjoint_pool implementation distinguishes between
a few different levels of logging (0-3). The argument
should be an int, not bool.
Without this change, setting UR_L0_USM_ALLOCATOR_TRACE or
SYCL_PI_LEVEL_ZERO_USM_ALLOCATOR_TRACE only had an effect
if UR_L0_USM_ALLOCATOR or SYCL_PI_LEVEL_ZERO_USM_ALLOCATOR
was also set.
@igchor
Copy link
Member Author

igchor commented Dec 13, 2023

I just realized there was one more problem. I fixed it in a separate commit.

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e69ed21) 15.70% compared to head (8ee650d) 15.74%.
Report is 16 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1172      +/-   ##
==========================================
+ Coverage   15.70%   15.74%   +0.03%     
==========================================
  Files         223      223              
  Lines       31518    31468      -50     
  Branches     3556     3557       +1     
==========================================
+ Hits         4951     4955       +4     
+ Misses      26516    26462      -54     
  Partials       51       51              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DamianDuy
Copy link

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants