[HIP] Remove inline from helper

[hdelan]

Different compilers can change the linkage of symbols based on whether inline is used. This removes the inline specifier so it has external linkage and can be called from within another TU.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (69a56ea) 15.72% compared to head (526f7e6) 15.72%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1178      +/-   ##
==========================================
- Coverage   15.72%   15.72%   -0.01%     
==========================================
  Files         223      223              
  Lines       31484    31484              
  Branches     3556     3556              
==========================================
- Hits         4952     4951       -1     
- Misses      26481    26482       +1     
  Partials       51       51              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ldrumm]

Now this function is visible, does it need to start with ur or some internal-private prefix?

@kbenzie will know

[kbenzie]

Now this function is visible, does it need to start with ur or some internal-private prefix?

@kbenzie will know

If this is only being made to have external linkage for use within the HIP adapter there is no need for it to have a ur preifx. We have linker scripts for stripping symbols which we don't want to be part of the official ABI of the adapters.

[hdelan]

Now this function is visible, does it need to start with ur or some internal-private prefix?

@kbenzie will know

This function already had external linkage with the compilers that I tested (gcc 11 and upstream clang) so it shouldn't need any change. Note that this only broke for gcc 12 since the func is called from another TU and gcc 12 seems to have some implementation defined behaviour that makes inline funcs have internal linkage

[ldrumm]

Thanks for clarifying

[hdelan]

Ping @oneapi-src/owner-unified-runtime can we merge this?

[kbenzie]

Ping @oneapi-src/owner-unified-runtime can we merge this?

We are working though the ready to merge backlog and will get to this as soon as we can.

[hdelan]

Thanks @kbenzie