[HIP] Add support for global variable read write #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1186 +/- ##
==========================================
- Coverage 15.73% 15.73% -0.01%
==========================================
Files 223 223
Lines 31478 31477 -1
Branches 3558 3558
==========================================
- Hits 4954 4953 -1
Misses 26473 26473
Partials 51 51 ☔ View full report in Codecov by Sentry. |
jchlanda
reviewed
Dec 15, 2023
hdelan
force-pushed
the
device-global-hip
branch
from
8b6cb00
to
57492fd
Compare
hdelan
commented
Dec 20, 2023
jchlanda
approved these changes
Dec 20, 2023
hdelan
force-pushed
the
device-global-hip
branch
from
57492fd
to
8f94997
Compare
Co-authored-by: Jakub Chlanda <j.chlanda@gmail.com>
Co-authored-by: Jakub Chlanda <j.chlanda@gmail.com>
hdelan
force-pushed
the
device-global-hip
branch
from
8ed8d96
to
45d76b7
Compare
|
Ping @oneapi-src/owner-unified-runtime can we merge this? |
Edit: Of course I notice intel/llvm#12165 it after posting this. |
|
@oneapi-src/owner-unified-runtime, gentle reminder for merge |
sarnex
pushed a commit
to intel/llvm
that referenced
this pull request
Jan 16, 2024
Enable `device_global` for AMDGPU. Related to oneapi-src/unified-runtime#1186 . In order for `hipModuleGetGlobal` to see a global symbol we need to not make the visibility of the symbol hidden. Perhaps changing this as a default is not always a good idea. Could also do this in the SYCL headers using an attribute to specify the visibility of the `device_global` var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intel/llvm#12165