[HIP] Support managed allocations in USM free

[npmiller]

In ROCm 5.7.1 some USM allocations are reported as managed, these are freed in the same way as device allocations.

Testing in intel/llvm#12380

[GeorgeWeb]

LGTM

[GeorgeWeb]

@npmiller This PR is fine as is. I just have a question that ties into the now finally used mananged memory type from ROCm v5.7.1 onwards. So I am wondering whether we need to address this also in urUSMGetMemAllocInfo where hipMemoryTypeManaged also isn't being checked as a valid memory object type.

[npmiller]

It does check this:

      Value = hipPointerAttributeType.isManaged;
      if (Value) {
        // pointer to managed memory
        return ReturnValue(UR_USM_TYPE_SHARED);
      }

I'm not sure if it's exactly the same thing though

[GeorgeWeb]

It does check this:

      Value = hipPointerAttributeType.isManaged;
      if (Value) {
        // pointer to managed memory
        return ReturnValue(UR_USM_TYPE_SHARED);
      }

I'm not sure if it's exactly the same thing though

The isManaged member is set for pointers to managed memory via the unified memory allocator in HIP so it should be okay. My bad I didn't spot the if (Value) was checking isManaged.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b66cf9b) 15.46% compared to head (3173420) 15.46%.
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1193   +/-   ##
=======================================
  Coverage   15.46%   15.46%           
=======================================
  Files         238      238           
  Lines       33883    33883           
  Branches     3747     3747           
=======================================
  Hits         5239     5239           
  Misses      28593    28593           
  Partials       51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[EwanC]

I bumped into an issue locally with shared USM while trying out HIP support for SYCL-Graphs on ROCM 5.7.1, and this patch fixed it, would be helpful to get this merged (or tagged ready-to-merge)

[kbenzie]

Rebasing should resolve the unrelated check failures.