Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CUDA] Implement urMemImageGetInfo #1213

Merged
merged 5 commits into from
Apr 10, 2024

Conversation

fabiomestre
Copy link
Contributor

@fabiomestre fabiomestre commented Dec 29, 2023

Adds support for the urMemImageGetInfo entrypoint.

To be able to match the new style for aborts and error codes used in #1127, I also cherry-picked the UR_RETURN_ON_FAILURE macro from that PR.

intel/llvm: intel/llvm#12287

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb83446) 15.72% compared to head (7ab3635) 15.46%.
Report is 169 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1213      +/-   ##
==========================================
- Coverage   15.72%   15.46%   -0.27%     
==========================================
  Files         223      238      +15     
  Lines       31475    33883    +2408     
  Branches     3557     3747     +190     
==========================================
+ Hits         4951     5239     +288     
- Misses      26473    28593    +2120     
  Partials       51       51              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabiomestre fabiomestre marked this pull request as ready for review January 4, 2024 14:35
@fabiomestre fabiomestre requested review from a team as code owners January 4, 2024 14:35
@fabiomestre fabiomestre requested a review from GeorgeWeb January 4, 2024 14:35
Copy link
Contributor

@GeorgeWeb GeorgeWeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adapter LGTM!

@fabiomestre fabiomestre added the ready to merge Added to PR's which are ready to merge label Feb 9, 2024
@kbenzie kbenzie self-assigned this Mar 15, 2024
@kbenzie kbenzie added conformance Conformance test suite issues. cuda CUDA adapter specific issues labels Apr 3, 2024
@kbenzie kbenzie force-pushed the fabio/imagegetinfo_cuda branch from 55c03aa to 46604be Compare April 10, 2024 11:25
@kbenzie kbenzie merged commit cda0cd9 into oneapi-src:main Apr 10, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conformance Conformance test suite issues. cuda CUDA adapter specific issues ready to merge Added to PR's which are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants