[urinfo] Fix printing of device UUID #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongreig
approved these changes
Jan 11, 2024
al42and
approved these changes
Jan 22, 2024
kbenzie
force-pushed
the
benie/fix-urinfo-device-uuid-printing
branch
from
744f2cf
to
dc97b7b
Compare
kbenzie
force-pushed
the
benie/fix-urinfo-device-uuid-printing
branch
from
dc97b7b
to
b8c4e60
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1243 +/- ##
==========================================
- Coverage 15.39% 15.38% -0.01%
==========================================
Files 240 240
Lines 34101 34116 +15
Branches 3776 3780 +4
==========================================
- Hits 5251 5250 -1
- Misses 28799 28815 +16
Partials 51 51 ☔ View full report in Codecov by Sentry. |
fabiomestre
approved these changes
Jan 30, 2024
kbenzie
force-pushed
the
benie/fix-urinfo-device-uuid-printing
branch
from
b8c4e60
to
f2c8da7
Compare
kbenzie
force-pushed
the
benie/fix-urinfo-device-uuid-printing
branch
from
f2c8da7
to
bba3971
Compare
kbenzie
force-pushed
the
benie/fix-urinfo-device-uuid-printing
branch
from
bba3971
to
a13a455
Compare
kbenzie
added a commit
to kbenzie/llvm
that referenced
this pull request
Mar 4, 2024
kbenzie
force-pushed
the
benie/fix-urinfo-device-uuid-printing
branch
from
a13a455
to
0e2b601
Compare
kbenzie
added
specification
kbenzie
force-pushed
the
benie/fix-urinfo-device-uuid-printing
branch
from
0e2b601
to
dc2bf5f
Compare
* Change the type returned by the `UR_DEVICE_INFO_UUID` query to `uint8_t` to match the type returned from Level Zero, CUDA, & HIP. * Modify template to emit call to `printDeviceUUID()` instead of generic info printer to special case output formatting. * Add `printDeviceUUID()` to print the device UUID in a human friendly format.
Check if the OpenCL device supports the `cl_khr_device_uuid` extension. If it is supported, use it to implement the `UR_DEVICE_INFO_UUID` query. Otherwise, continue to return `UR_RESULT_ERROR_UNSUPPORTED_ENUMERATION`.
kbenzie
force-pushed
the
benie/fix-urinfo-device-uuid-printing
branch
from
dc2bf5f
to
6a60213
Compare
steffenlarsen
pushed a commit
to intel/llvm
that referenced
this pull request
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UR_DEVICE_INFO_UUIDquery touint8_tto match the type returned from Level Zero, CUDA, & HIP.printDeviceUUID()instead of generic info printer to special case output formatting.printDeviceUUID()to print the device UUID in a human friendly format.