-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NATIVECPU] Empty implementation for command buffer fill #1247
[NATIVECPU] Empty implementation for command buffer fill #1247
Conversation
There's another couple of command-buffer entry-points added recently that we missed from native-cpu #937
Not sure if you want to include those here or a new PR (happy for you to include them here) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1247 +/- ##
=======================================
Coverage 15.57% 15.57%
=======================================
Files 233 233
Lines 32088 32088
Branches 3638 3638
=======================================
Hits 4999 4999
Misses 27038 27038
Partials 51 51 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Pietro would you mind removing the die
calls and just leave these entry points as return UR_RESULT_ERROR_UNSUPPORTED_FEATURE
? We're removing die/abort (#1127) and handling it in DPC++ (intel/llvm#12361). Cheers!
Thanks for pointing it out, I'll include them here |
Will do, thanks :) |
81f5512
to
f6918cb
Compare
f6918cb
to
2bd41d7
Compare
Adds implementations for `piextCommandBufferMemBufferFill` and `piextCommandBufferFillUSM`. Unified Runtime PR: oneapi-src/unified-runtime#1247
Adds empty implementations for
urCommandBufferAppendMemBufferFillExp
andurCommandBufferAppendUSMFillExp
on Native CPU.intel/llvm PR: intel/llvm#12379