Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NATIVECPU] Empty implementation for command buffer fill #1247

Merged
merged 4 commits into from
Jan 24, 2024

Conversation

PietroGhg
Copy link
Contributor

@PietroGhg PietroGhg commented Jan 12, 2024

Adds empty implementations for urCommandBufferAppendMemBufferFillExp and urCommandBufferAppendUSMFillExp on Native CPU.
intel/llvm PR: intel/llvm#12379

@EwanC
Copy link
Contributor

EwanC commented Jan 12, 2024

There's another couple of command-buffer entry-points added recently that we missed from native-cpu #937

  • urCommandBufferAppendUSMPrefetchExp
  • urCommandBufferAppendUSMAdviseExp.

Not sure if you want to include those here or a new PR (happy for you to include them here)

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (92f44da) 15.57% compared to head (2bd41d7) 15.57%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1247   +/-   ##
=======================================
  Coverage   15.57%   15.57%           
=======================================
  Files         233      233           
  Lines       32088    32088           
  Branches     3638     3638           
=======================================
  Hits         4999     4999           
  Misses      27038    27038           
  Partials       51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@martygrant martygrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Pietro would you mind removing the die calls and just leave these entry points as return UR_RESULT_ERROR_UNSUPPORTED_FEATURE? We're removing die/abort (#1127) and handling it in DPC++ (intel/llvm#12361). Cheers!

@PietroGhg
Copy link
Contributor Author

There's another couple of command-buffer entry-points added recently that we missed from native-cpu #937

* `urCommandBufferAppendUSMPrefetchExp`

* `urCommandBufferAppendUSMAdviseExp`.

Not sure if you want to include those here or a new PR (happy for you to include them here)

Thanks for pointing it out, I'll include them here

@PietroGhg
Copy link
Contributor Author

Hey Pietro would you mind removing the die calls and just leave these entry points as return UR_RESULT_ERROR_UNSUPPORTED_FEATURE? We're removing die/abort (#1127) and handling it in DPC++ (intel/llvm#12361). Cheers!

Will do, thanks :)

@PietroGhg PietroGhg added the ready to merge Added to PR's which are ready to merge label Jan 15, 2024
@kbenzie kbenzie merged commit 8d3233a into oneapi-src:main Jan 24, 2024
51 checks passed
sommerlukas pushed a commit to intel/llvm that referenced this pull request Jan 26, 2024
Adds implementations for `piextCommandBufferMemBufferFill` and
`piextCommandBufferFillUSM`.
Unified Runtime PR:
oneapi-src/unified-runtime#1247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Added to PR's which are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants