Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SanitizerLayer] Fix resource leaks in "san_utils.cpp" #1312

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

AllanZyne
Copy link
Contributor

@AllanZyne AllanZyne commented Feb 2, 2024

This resolves coverity issues:

Resource leaks (RESOURCE_LEAK)
Variable "handle" going out of scope leaks the storage it points to.

Incorrect expression (BAD_COMPARE)
This implicit conversion to a function pointer is suspicious: "__asan_init != NULL".

@AllanZyne AllanZyne requested a review from a team as a code owner February 2, 2024 13:20
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (cd97e17) 15.39% compared to head (e4b5b89) 15.39%.

Files Patch % Lines
source/loader/layers/sanitizer/linux/san_utils.cpp 16.66% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1312   +/-   ##
=======================================
  Coverage   15.39%   15.39%           
=======================================
  Files         240      240           
  Lines       34122    34122           
  Branches     3779     3779           
=======================================
+ Hits         5252     5254    +2     
+ Misses      28819    28818    -1     
+ Partials       51       50    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pbalcer pbalcer merged commit f086f36 into oneapi-src:main Feb 6, 2024
52 checks passed
@AllanZyne AllanZyne deleted the fix-coverity/sanitizer-layer branch April 3, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants