Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPENCL] Refactor ext functions caching #1325

Conversation

omarahmed1111
Copy link
Contributor

@omarahmed1111 omarahmed1111 commented Feb 8, 2024

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (78ef1ca) 14.82% compared to head (58ba98b) 12.72%.
Report is 11 commits behind head on main.

Files Patch % Lines
...e/common/umf_pools/disjoint_pool_config_parser.cpp 0.00% 15 Missing ⚠️
source/common/umf_helpers.hpp 0.00% 9 Missing ⚠️
source/common/logger/ur_logger_details.hpp 61.53% 5 Missing ⚠️
test/usm/usmPoolManager.cpp 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1325      +/-   ##
==========================================
- Coverage   14.82%   12.72%   -2.10%     
==========================================
  Files         250      238      -12     
  Lines       36220    35338     -882     
  Branches     4094     4010      -84     
==========================================
- Hits         5369     4498     -871     
- Misses      30800    30836      +36     
+ Partials       51        4      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omarahmed1111 omarahmed1111 force-pushed the Refactor-ext-functions-caching branch 4 times, most recently from 58ba98b to 661b198 Compare February 14, 2024 14:48
@kbenzie kbenzie added the opencl OpenCL adapter specific issues label Apr 10, 2024
@kbenzie
Copy link
Contributor

kbenzie commented Nov 8, 2024

Closing as this is based on the old version of #1176 and everything now conflicts.

@kbenzie kbenzie closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
opencl OpenCL adapter specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants